-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yofi: fix build #344811
yofi: fix build #344811
Conversation
Hey @ocfox , I believe it would be easier to follow the upstream repo changes rather than making a patch yourselves. You can update the rev of yofi itself as the |
Maybe patch cargo.lock more cleaner? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didn't realize this was a patch from a fork; we probably shouldn't be using it then
l4l/yofi@09901e7 would be a better candidate. I'd recommend continuing to pull it in as a patch though, since unstable versions can introduce issues we don't intend
I just realized that I tried, because of |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.