Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bun: 1.1.27 -> 1.1.29 #343120

Merged
merged 1 commit into from
Sep 20, 2024
Merged

bun: 1.1.27 -> 1.1.29 #343120

merged 1 commit into from
Sep 20, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Sep 19, 2024 •
edited
Loading

Description of changes

oven-sh/bun@bun-v1.1.27...bun-v1.1.29

#332639 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@afh afh mentioned this pull request Sep 20, 2024
Merged
@afh afh added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Sep 20, 2024
@afh
Copy link
Member

afh commented Sep 20, 2024

Result of nixpkgs-review pr 343120 run on x86_64-linux 1

2 packages built:
  • bun
  • helix-gpt

@afh afh added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 20, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1966

@uncenter
Copy link
Member

https://github.com/oven-sh/bun/releases/tag/bun-v1.1.29 is out now as well.

@wegank wegank changed the title bun: 1.1.27 -> 1.1.28 bun: 1.1.27 -> 1.1.29 Sep 20, 2024
@ofborg ofborg bot requested a review from thilobillerbeck September 20, 2024 13:12
@uncenter
Copy link
Member

Result of nixpkgs-review pr 343120 run on aarch64-darwin 1

2 packages built:
  • bun
  • helix-gpt

@wegank
Copy link
Member Author

wegank commented Sep 20, 2024

Result of nixpkgs-review pr 343120 run on aarch64-linux 1

2 packages built:
  • bun
  • helix-gpt

@afh
Copy link
Member

afh commented Sep 20, 2024

Result of nixpkgs-review pr 343120 run on x86_64-linux 1

2 packages built:
  • bun
  • helix-gpt

@afh afh removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Sep 20, 2024
@NickCao NickCao merged commit 6edbe42 into NixOS:master Sep 20, 2024
30 of 32 checks passed
@wegank wegank deleted the bun-bump branch September 21, 2024 09:25
@domenkozar
Copy link
Member

I'm getting

dyld[55972]: Symbol not found: _ubrk_clone
  Referenced from: /nix/store/1hn8dddmy3l99x502d0fqz901gfk74px-bun-1.1.29/bin/bun
  Expected in: /usr/lib/libicucore.A.dylib
/nix/store/khdyzjph6755ldcld7a4v8fxc5aw3s41-init-bun.sh: line 3: 55972 Abort trap: 6           /nix/store/1hn8dddmy3l99x502d0fqz901gfk74px-bun-1.1.29/bin/bun install --yarn

@domenkozar
Copy link
Member

domenkozar commented Oct 2, 2024 •
edited
Loading

Seems like it needs newer Apple SDK: oven-sh/bun#6035

@domenkozar domenkozar mentioned this pull request Oct 7, 2024
Merged
10 tasks
@shyim
Copy link
Member

shyim commented Oct 7, 2024

@domenkozar nix downloads the pre-build files, why should it break here 🤔 ?
The nix package works for me Sequoia 15.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter approved these changes

@NickCao NickCao NickCao approved these changes

@afh afh afh approved these changes

@diogomdp diogomdp Awaiting requested review from diogomdp

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

@cdmistman cdmistman Awaiting requested review from cdmistman

@DAlperin DAlperin Awaiting requested review from DAlperin

@thilobillerbeck thilobillerbeck Awaiting requested review from thilobillerbeck

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wegank @afh @nixos-discourse @uncenter @domenkozar @shyim @thilobillerbeck @NickCao