xlsxgrep: drop #340582
Merged
xlsxgrep: drop #340582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
pbsds
added
the
2.status: merge conflict
|
dropping seems like a sane choice. Please fix merge conflict and rename to |
|
please also add an entry in pkgs/top-level/aliases.nix |
felixscheinost
force-pushed
the
remove-xlsxgrep
branch
from
e8fa48f
to
636bf47
Compare
Remove xlsxgrep The last update from 0.0.23 to 0.0.29 broke it as it switched from xlrd to pyexcel. I tried switching to pyexcel but pyexcel-xlsx (for .xlsx support - important) isn't packaged yet. I tried packaging it but pyexcel-xlsx doesn't seem to be actively maintained anymore and isn't compatible with the most recent openpyxl version. I also considered downgrading to 0.0.23 but xlrd is unmaintained and recommends openpyxl.
felixscheinost
force-pushed
the
remove-xlsxgrep
branch
from
636bf47
to
4552cd2
Compare
|
@pbsds Thanks for the feedback! Rebased, changed commit message and added to |
pbsds
approved these changes
Nov 1, 2024
|
ZHF #352882 |
wegank
added
the
12.approvals: 1
gepbird
added
0.kind: ZHF Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The last update from 0.0.23 to 0.0.29 (broke it as it switched from xlrd to pyexcel.
I approved the PR but seems I messed something up during testing (#335019).
I tried switching to pyexcel but pyexcel-xlsx (for .xlsx support - important) isn't packaged yet. I tried packaging it but pyexcel-xlsx doesn't seem to be actively maintained anymore and isn't compatible with the most recent openpyxl version (pyexcel/pyexcel-xlsx#52).
I also considered downgrading to 0.0.23 but xlrd is unmaintained and recommends openpyxl.
Not sure what to do about this.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.