Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.lomiri*: Init online accounts manager & settings plugin #340391

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Sep 7, 2024

Description of changes

Working towards #99090.

This inits:

This also fixes an issue with the localisation in LSS, which I didn't spot in the latest OTA update.

The settings app page shows up, but without any services being listed by default. This behaviour is identical to what happens on Debian if I build the involved packages there, so not sure what's wrong. Don't have a device to test it on UBtouch. Seems to be expected behaviour, see #340391 (comment) for reason.

I don't think this is urgently needed, so I'll leave this as-is and see if there's any updates upstream on this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 7, 2024
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-online-accounts branch from c2c14c5 to e5acf20 Compare September 7, 2024 22:16
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 7, 2024
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-online-accounts branch from e5acf20 to 0445b3c Compare September 8, 2024 16:58
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-online-accounts branch from 0445b3c to bd87427 Compare September 8, 2024 17:05
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Sep 8, 2024

@ofborg build nixosTests.lomiri

@OPNA2608
Copy link
Contributor Author

After some more prodding, I think this just needs packages that actually provide accountsservice applications & services for the settings entry to provide account creation options. lomiri-sync-monitor seems to be providing some, which show up when running the settings app in the PDK.

Bildschirmfoto_2024-09-20_00-29-04

So I think this is fine as-is for now? And I'll give this another look when I get to the sync monitor (which has its own list of dependencies that need to be init'd first, sigh).

@OPNA2608 OPNA2608 marked this pull request as ready for review September 19, 2024 22:47
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-online-accounts branch from ecb9543 to 9d8afc0 Compare September 29, 2024 15:04
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-online-accounts branch from 9d8afc0 to a87fea2 Compare September 29, 2024 15:06
@OPNA2608 OPNA2608 marked this pull request as draft September 29, 2024 17:43
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-online-accounts branch from a87fea2 to d841046 Compare September 29, 2024 19:19
@OPNA2608
Copy link
Contributor Author

Inching closer to a working state, but still not really done.

Bildschirmfoto_2024-09-29_21-16-30
Bildschirmfoto_2024-09-29_21-16-57

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants