gurk-rs: 0.4.3 -> 0.5.1

[devhell]

Description of changes

Related #332957

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Scrumplex]

Result of nixpkgs-review pr 340311 run on x86_64-linux 1

1 package built:

• gurk-rs

[Scrumplex]

I tried to link my device but I got the following error:

Error: failed to provision device: Service error: Unexpected response: HTTP 409

Caused by:
    0: Service error: Unexpected response: HTTP 409
    1: Unexpected response: HTTP 409

[devhell]

I tried to link my device but I got the following error:

Error: failed to provision device: Service error: Unexpected response: HTTP 409

Caused by:
    0: Service error: Unexpected response: HTTP 409
    1: Unexpected response: HTTP 409

This was fixed in 0.5.1. Are you sure you're executing the built binary and not the old 0.4.3 binary?

[Scrumplex]

This was fixed in 0.5.1. Are you sure you're executing the built binary and not the old 0.4.3 binary?

I was running it in the shell generated by nixpkgs-review, I don't have gurk in my PATH outside of it :O

I have entered the nixpkgs-review shell again and gurk -V yields gurk 0.5.1

Edit:

debug log output:

2024-09-07T21:32:56.952451Z  INFO presage::manager::linking: generating qrcode from provisioning link: sgnl://linkdevice?uuid=[redacted]&pub_key=[redacted]    
2024-09-07T21:33:07.637036Z  WARN libsignal_service_hyper::websocket: Websocket closing: Some(CloseFrame { code: Normal, reason: "Closed" })
2024-09-07T21:33:07.637085Z ERROR libsignal_service::websocket: SignalWebSocket: Websocket error: end of web request stream; socket closing
2024-09-07T21:33:07.923850Z ERROR put_json{service=Service path="/v1/devices/link" additional_headers=[] credentials_override=Identified(HttpAuth { username: "[redacted]" })}:request{method=PUT endpoint=Service additional_headers=[] credentials_override=Identified(HttpAuth { username: "[redacted]" }) path=/v1/devices/link}: libsignal_service_hyper::push_service: Failed to decode HTTP 409 response: Error decoding JSON response: missing field `missingDevices` at line 1 column 42

[devhell]

This was fixed in 0.5.1. Are you sure you're executing the built binary and not the old 0.4.3 binary?

I was running it in the shell generated by nixpkgs-review, I don't have gurk in my PATH outside of it :O

I have entered the nixpkgs-review shell again and gurk -V yields gurk 0.5.1

Edit:

debug log output:

2024-09-07T21:32:56.952451Z  INFO presage::manager::linking: generating qrcode from provisioning link: sgnl://linkdevice?uuid=[redacted]&pub_key=[redacted]    
2024-09-07T21:33:07.637036Z  WARN libsignal_service_hyper::websocket: Websocket closing: Some(CloseFrame { code: Normal, reason: "Closed" })
2024-09-07T21:33:07.637085Z ERROR libsignal_service::websocket: SignalWebSocket: Websocket error: end of web request stream; socket closing
2024-09-07T21:33:07.923850Z ERROR put_json{service=Service path="/v1/devices/link" additional_headers=[] credentials_override=Identified(HttpAuth { username: "[redacted]" })}:request{method=PUT endpoint=Service additional_headers=[] credentials_override=Identified(HttpAuth { username: "[redacted]" }) path=/v1/devices/link}: libsignal_service_hyper::push_service: Failed to decode HTTP 409 response: Error decoding JSON response: missing field `missingDevices` at line 1 column 42

Hmmm, ok, I have had that issue with 0.4.3, and upstream fixed it apparently in this version. I can't reproduce your issue on my side. I can try to have another go at it tomorrow. I think the best way to proceed would be to perhaps open an issue with upstream for your case? Sorry about this.

[devhell]

@Scrumplex, so I've tested it again. Removed ~/.config/gurk and started version 0.5.1 again from fresh, which created a QR code, which I then scanned, and it linked successfully. The issue upstream fixed is described in this issue: boxdot/gurk-rs#298

[devhell]

@alyssais can this be merged now, please?

[Scrumplex]

Packaging changes LGTM