watchmate: 0.4.5 -> 0.5.2-unstable-2024-08-13 #340066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
alyssais
reviewed
Sep 6, 2024
| rustPlatform.buildRustPackage rec { | ||
| pname = "watchmate"; | ||
| version = "0.4.5"; | ||
| _version = "0.5.2"; |
| @@ -10,22 +10,24 @@ | |||
| , wrapGAppsHook4 | |||
| , glib | |||
| }: | |||
|
|
|||
| let appid = "io.gitlab.azymohliad.WatchMate"; | |||
There was a problem hiding this comment.
This doesn't seem likely to change, so why not leave it inlined?
There was a problem hiding this comment.
no real reason other than aesthetics tbh
aktaboot
force-pushed
the
bump-watchmate
branch
from
6370d3b
to
7e0e797
Compare
alyssais
reviewed
Sep 6, 2024
| @@ -10,22 +10,24 @@ | |||
| , wrapGAppsHook4 | |||
| , glib | |||
| }: | |||
|
|
|||
| let | |||
| _version = "0.5.2"; | |||
There was a problem hiding this comment.
Indentation is off here. version' might be a more idiomatic name.
There was a problem hiding this comment.
Or release or releaseVersion if we want to avoid meaningful symbols.
There was a problem hiding this comment.
sure thing! thanks for the feedback :)
aktaboot
force-pushed
the
bump-watchmate
branch
2 times, most recently
from
2cb5e3f
to
ecb4e0f
Compare
|
hmm, I should've split the formatting in a different commit I guess |
|
Yeah, please do. In the same commit it's quite hard to review. |
aktaboot
force-pushed
the
bump-watchmate
branch
from
ecb4e0f
to
2cb5e3f
Compare
aktaboot
force-pushed
the
bump-watchmate
branch
from
2cb5e3f
to
7e208d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update watchmate, includes fix for Rust 1.80.0 breakage
Related #332957
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.