etesync-dav: 0.32.1 -> 0.32.1-unstable-2024-09-02

[ghpzin]

Diff: etesync/etesync-dav@v0.32.1...b9b23bf

• contains commit pulled previously pulled with fetchpatch:
  https://www.github.com/etesync/etesync-dav/commit/040cb7b57205e70515019fb356e508a6414da11e
• contains commit with changes to log.set_level() from radicale 3.2.2 update (additional second arg - backtrace_on_debug):
  https://www.github.com/Kozea/Radicale/pull/1519
  https://www.github.com/etesync/etesync-dav/pull/318

Description of changes

Since radicale update to 3.2.2 (#321108) etesync-dav fails during runtime with error related to changes to log.set_level (additional second arg).

Fixes test run of nixosTests.etesync-dav (fails since 2024-06-20 - merge of radicale update):
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.etesync-dav.x86_64-linux
https://hydra.nixos.org/build/270729013

Error log:

machine # Traceback (most recent call last):
machine #   File "/nix/store/wd2by7xjf0cx15nwdxg395x0zsfja50g-etesync-dav-0.32.1/bin/.etesync-dav-wrapped", line 164, in <module>
machine #     radicale_main.run(radicale_args + sys.argv[1:])
machine #   File "/nix/store/wd2by7xjf0cx15nwdxg395x0zsfja50g-etesync-dav-0.32.1/lib/python3.12/site-packages/etesync_dav/radicale_main/__init__.py", line 136, in run
machine #     log.set_level(configuration.get("logging", "level"))
machine # TypeError: set_level() missing 1 required positional argument: 'backtrace_on_debug'

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ghpzin]

@ofborg test etesync-dav

[aktaboot]

Maybe a better approach would be to update this package to latest upstream commit and remove patches since they have all been merged now.

I have tested that and it seems to work fine,

but maybe we have a reason to prefer fetchPypi over fetchFromGitHub I am not aware of

[ghpzin]

Removed 2 patches, converted to update to 0.32.1-unstable-2024-09-02
Looked through commits and there did not seem to be anything else that should have changed behavior other than 2 patches we already pulled.

[aktaboot]

I tested this and it is working as expected :)

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4536

[kraftnix]

Can also confirm this works perfectly.

[aktaboot]

Merge! 🪄