Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn-auth-ldap: Fix CVE-2024-28820 #337962

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Conni2461
Copy link
Member

Description of changes

fixes CVE-2024-28820 by including patch from threerings/openvpn-auth-ldap#92

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Conni2461 Conni2461 force-pushed the fix/cve-openvpn-auth-ldap branch from 40e9042 to a4d51ec Compare August 28, 2024 18:25
Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you for noticing this one. If this upstream repo is as abandoned as it looks, we might eventually have to drop it from nixpkgs, unless there's a fork somewhere that is still maintained.

@benley benley merged commit 1906fbb into NixOS:master Aug 29, 2024
29 of 31 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
@Conni2461 Conni2461 deleted the fix/cve-openvpn-auth-ldap branch August 29, 2024 17:59
dasJ pushed a commit that referenced this pull request Aug 30, 2024
openvpn-auth-ldap: Fix CVE-2024-28820 (#337962)

(cherry picked from commit 1906fbb)

Co-authored-by: Simon Hauser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants