Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector: fix compatibility with Rust 1.80 #336302

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 21, 2024

Description of changes

Rust 1.80 broke a lot of crates (#332957), including Vector. Upstream is working on a proper upgrade (vectordotdev/vector#20949), but for now we can get it to build again by turning off the offending lint (the behaviour is as legal as it was before, it's just not declared to be intentional).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nightkr
Copy link
Member Author

nightkr commented Aug 21, 2024

All NixOS tests pass except for syslog-quickwit, which fails to compile quickwit because it is still using an old time (#332957).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants