nix-serve: 0.2-e4675e3 -> unstable-2024-04-08 #331230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
changed the title
flokli
changed the title
flokli
added a commit
to flokli/nix-serve
that referenced
this pull request
Jul 31, 2024
`nix dump-path` regressed, and now requires flakes to be enabled, breaking nix-serve on systems without flakes being enabled. However, `nix-store --dump` works fine across the board, so use that. Nix issue: NixOS/nix#11225 Workaround in nixpkgs: NixOS/nixpkgs#331230
This was referenced Jul 31, 2024
The current version in nixpkgs is from 2018, and there's been a lot of fixes and features since then. Passthru tests failed, as nix-serve seems to be shelling out to a `nix-command` which needs an explicitly enabled since some Nix versions: ``` machine # [ 5.920336] nix-serve-start[840]: error: experimental Nix feature 'nix-command' is disabled; use '--extra-experimental-features nix-command' to override ``` Rather than patching this, I fixed it by giving nix-serve a Nix binary in $PATH that doesn't require that - while keeping the nix.perlBindings. The passthru tests now succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version in nixpkgs is from 2018, and there's been a lot of fixes and features since then.
Passthru tests failed, as nix-serve seems to be shelling out to a
nix-commandwhich needs an explicitly enabled since some Nix versions:Rather than patching this, I fixed it by giving nix-serve a Nix binary in $PATH that doesn't require that - while keeping the nix.perlBindings.
The passthru tests now succeed.
Closes #219337.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.