-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project-lemonlime: init at 0.3.5 #329904
project-lemonlime: init at 0.3.5 #329904
Conversation
3cf7507
to
2ef9d1c
Compare
@Sigmanificient We should provide a way to user that make sure the compiler's path won't change. It won't detect PATH every time when started but just save them into a config file. It is in
It could be better if we can generate config file by nix. It should be included in home-manager. Anyway, please support darwin as well. |
Well we cant really control anything outside the package, but the compiler path would not change unless the user changes its version |
@Sigmanificient I means that we could create a wrap shell and provide a option in nixpkgs for user to choose their compiler. Or it will be a mess if the compiler path is changed. |
I dont understand what you are referring by |
@Sigmanificient I means we provide the compiler path to lemonlime in some ways that user won't worry about the diffrent compiler path. We use |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4434 |
Darwin need to load more library. However I haven't got device to test. Could you mark it as |
2ef9d1c
to
fd0858f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your fixes isn't written in a way that GitHub recognizes it. It should be written:
Fixes #329546
The filename, like the pname, should be hyphenated instead of underscored.
fd0858f
to
47b9c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't think a meta.homepage
is required?
47b9c8c
to
e860604
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1942 |
|
||
nativeBuildInputs = [ | ||
cmake | ||
qt5.wrapQtAppsHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qt 6 should be preferred if there are no issues with it. Upstream provided https://github.com/Project-LemonLime/Project_LemonLime/blob/master/CMakeLists.txt#L47
(Also qt6.qtwayland!)
Description of changes
Fixes: #329546
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.