-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koboldcpp: fix CUDA_DOCKER_ARCH make flag #329426
Conversation
- Previously, the value was "assembled" using additional logic, but when switching to a different method, an oversight was made, and `sm_` was forgotten to be removed
The |
95d5959
to
1b8d42d
Compare
(lib.optionals cublasSupport "CUDA_DOCKER_ARCH=${builtins.head cudaArches}") | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(lib.optionals cublasSupport "CUDA_DOCKER_ARCH=${builtins.head cudaArches}") | |
]; | |
] ++ lib.optionals cublasSupport [ "CUDA_DOCKER_ARCH=${builtins.head cudaArches}" ]; |
I guess...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
1b8d42d
to
db9fe54
Compare
Result of 1 package failed to build:
|
Closed in favor of #330038 |
Description of changes
sm_
was forgotten to be removedThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.