Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-library: use gettext from nixpkgs #328598

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

reckenrode
Copy link
Contributor

Description of changes

The vendored gettext fails to build with clang 16 on Darwin. The gettext in nixpkgs works.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@reckenrode reckenrode marked this pull request as draft July 20, 2024 06:23
@reckenrode
Copy link
Contributor Author

Setting to draft until I can look into and respond to #328588 (comment).

The vendored gettext fails to build with clang 16 on Darwin. The gettext in nixpkgs works.
@reckenrode reckenrode marked this pull request as ready for review July 20, 2024 13:32
@reckenrode
Copy link
Contributor Author

Setting back to ready after updating it per the feedback I got in #328588 (since it’s the same underlying issue being fixed).

@reckenrode reckenrode merged commit 43b7874 into NixOS:master Jul 23, 2024
26 checks passed
@reckenrode reckenrode deleted the icon-library-fixes branch July 23, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants