nodejs_18: fix build with python312 #324362
Conversation
| @@ -16,6 +16,8 @@ let | |||
| buildPackages = buildPackages // { stdenv = ensureCompatibleCC buildPackages; }; | |||
| python = python311; | |||
| }; | |||
|
|
|||
| python312Patches = callPackage ./python312-v18-patches.nix { }; | |||
There was a problem hiding this comment.
We're currently pinning Python 3.11 already, can we drop this for now?
There was a problem hiding this comment.
Some of the Python 3.12 commits were backported and released upstream (see https://github.com/nodejs/node/blob/v18.20.3/doc/changelogs/CHANGELOG_V18.md#commits-3), I’m not really sure whether we should be using Python 3.11 instead of fully backporting other changes required for Python 3.12 🤔
There was a problem hiding this comment.
We don't want any more rebuilds for this staging-next, in the future we'll want to switch to 3.12.
|
I've cherry-picked the node_22 changes to staging-next, node_18 can go to staging proper. |
aduh95
added
the
2.status: merge conflict
|
Needs rebasing. Is this still relevant? I see there was an upstream release on July 8; did that include these fixes? |
|
I’m working on a larger refactor of the Node.js package and I’ll probably include these patches instead of rebasing this PR. |
Description of changes
Fixes Python 3.12 compatibility for Node.js v18.
Split from #262124 (see #262124 (comment)).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.