-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs_20: 20.14.0 -> 20.15.0 #321292
nodejs_20: 20.14.0 -> 20.15.0 #321292
Conversation
Cherry-picked a commit to account for the failing tests, see #313982 (comment) |
Can you squash all your commits into one single commit? |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-321292-to-release-24.05 origin/release-24.05
cd .worktree/backport-321292-to-release-24.05
git switch --create backport-321292-to-release-24.05
git cherry-pick -x c1a9808e31ab0be4f63d61f0e863d7a29d3bcc98 |
You ticked that it builds on aarch64-darwin? Before this update it won't build (#322145, example hydra build) and this update doesn't seem to fix that (tried locally). |
It's possible that something else in |
Yes you're right, I tried locally on top of |
Not a problem. I think it's usually better, as building against |
Though of course, it will be great if someone fixes the issue, even if not introduced by this update. |
I think that's what #262124 is up to :) |
(cherry picked from commit 92bc04e)
Description of changes
https://github.com/nodejs/node/releases/tag/v20.15.0
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.