Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs_20: 20.14.0 -> 20.15.0 #321292

Merged
merged 1 commit into from
Jun 26, 2024
Merged

nodejs_20: 20.14.0 -> 20.15.0 #321292

merged 1 commit into from
Jun 26, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 20, 2024

Description of changes

https://github.com/nodejs/node/releases/tag/v20.15.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 21, 2024

Cherry-picked a commit to account for the failing tests, see #313982 (comment)

pkgs/development/web/nodejs/v20.nix Outdated Show resolved Hide resolved
pkgs/development/web/nodejs/v20.nix Outdated Show resolved Hide resolved
@drupol
Copy link
Contributor

drupol commented Jun 23, 2024

Can you squash all your commits into one single commit?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 24, 2024
@dasJ dasJ merged commit 92bc04e into NixOS:staging Jun 26, 2024
25 checks passed
@aduh95 aduh95 deleted the patch-2 branch June 26, 2024 12:16
@aduh95 aduh95 added the backport release-24.05 Backport PR automatically label Jun 28, 2024
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-321292-to-release-24.05 origin/release-24.05
cd .worktree/backport-321292-to-release-24.05
git switch --create backport-321292-to-release-24.05
git cherry-pick -x c1a9808e31ab0be4f63d61f0e863d7a29d3bcc98

@vcunat
Copy link
Member

vcunat commented Jul 1, 2024

You ticked that it builds on aarch64-darwin? Before this update it won't build (#322145, example hydra build) and this update doesn't seem to fix that (tried locally).

@vcunat
Copy link
Member

vcunat commented Jul 1, 2024

It's possible that something else in master..staging-next broke this, of course. (and you e.g. built atop master)

@aduh95
Copy link
Contributor Author

aduh95 commented Jul 1, 2024

Yes you're right, I tried locally on top of master, then remembered I have to target staging for this package, and did not re-try the build after the rebase.

@vcunat
Copy link
Member

vcunat commented Jul 1, 2024

Not a problem. I think it's usually better, as building against staging head would typically have a bad ratio of work/benefit. (staging-next sometimes, but depends on timing...)

@vcunat
Copy link
Member

vcunat commented Jul 1, 2024

Though of course, it will be great if someone fixes the issue, even if not introduced by this update.

@aduh95
Copy link
Contributor Author

aduh95 commented Jul 1, 2024

I think that's what #262124 is up to :)

@tie tie mentioned this pull request Jul 2, 2024
12 tasks
aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nodejs 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants