doc/haskell: Dedup and edit justStaticExecutables #319298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure all relevant info is in the user manual and avoid duplication of efforts, or things going out of sync.
roberth
requested review from
sternenseemann,
maralorn and
ncfavier
as code owners
github-actions
bot
added
6.topic: haskell
8.has: documentation
roberth
commented
Jun 12, 2024
| @@ -929,10 +929,12 @@ for this to work. | |||
| Haskell dependencies, but will still link dynamically against libc, GMP and | |||
| other system library dependencies. | |||
|
|
|||
| If the library being built or its dependencies use their Cabal-generated | |||
| If a library or its dependencies use their Cabal-generated | |||
There was a problem hiding this comment.
IIRC the doc team recommends a single line per sentence, so that we don't have to reflow. I haven't done the reflowing to keep the diff readable.
ofborg
bot
added
10.rebuild-darwin: 0
maralorn
approved these changes
Jun 12, 2024
|
May be worth backporting? |
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Make sure all relevant info is in the user manual and avoid duplication of efforts or things going out of sync.
The feature was introduced in
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.