openjdk22: remove redundant let binding

[jlesquembre]

With the new mkDerivation (finalAttrs: {}) pattern, the

let
... 
openjdk = mkDerivation ... ; in
openjdk

is no longer necessary.

It can be simplified to just

let ... in
mkDerivation ...

Continuation of #306616

Notice that while the diff seems quite large, it's mostly whitespace. The derivation remains the same; in fact, openjdk22 isn't rebuilt after this change.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[doronbehar]

Verified locally that:

$ git show --ignore-space-change
commit 28d29422b25062e8fd558b00b602f5581918cdb4
Author: José Luis Lafuente <[email protected]>
Date:   Mon Jun 10 11:14:47 2024 +0200

    openjdk22: remove redundant let binding
    
    With the new `mkDerivation (finalAttrs: {})` pattern, the
    ```
    let openjdk = ... ; in
    openjdk
    ```
    is no longer necessary

diff --git a/pkgs/development/compilers/openjdk/22.nix b/pkgs/development/compilers/openjdk/22.nix
index 9cdec758544c..97d1a3b3b44d 100644
--- a/pkgs/development/compilers/openjdk/22.nix
+++ b/pkgs/development/compilers/openjdk/22.nix
@@ -59,8 +59,9 @@ let
 
   # when building a headless jdk, also bootstrap it with a headless jdk
   openjdk-bootstrap = openjdk22-bootstrap.override { gtkSupport = !headless; };
+in
 
-  openjdk = stdenv.mkDerivation (finalAttrs: {
+stdenv.mkDerivation (finalAttrs: {
   pname = "openjdk" + lib.optionalString headless "-headless";
   inherit version;
 
@@ -272,6 +273,4 @@ let
 
     inherit gtk3;
   };
-  });
-in
-openjdk
+})

Also Ofborg says there is no difference in the final evaluation.