Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.lomiri-filemanager-app: init at 1.0.4 #316240

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

OPNA2608
Copy link
Contributor

Description of changes

Working towards #99090.

Lomiri Filemanager App. Self-explanatory.
Bildschirmfoto_2024-05-31_21-56-40

It's also one of the most flexible ways of sending files for content-hub transfers, so it's very much desired for a usable desktop experience.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 31, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 31, 2024
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 31, 2024

@ofborg build nixosTests.lomiri

@OPNA2608 OPNA2608 marked this pull request as draft May 31, 2024 22:41
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-filemanager-app branch from f3b50a7 to 17b83a5 Compare June 1, 2024 19:04
@OPNA2608 OPNA2608 marked this pull request as ready for review June 1, 2024 19:20
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-filemanager-app branch from 17b83a5 to e64ab6e Compare June 6, 2024 20:27
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good for me, 2 small things:

  1. Use runTest
  2. Pass the new files you're introducing through nixfmt-rfc-style

@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-filemanager-app branch from e64ab6e to 9fa4b5a Compare June 7, 2024 09:34
@OPNA2608 OPNA2608 marked this pull request as draft June 7, 2024 09:35
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-filemanager-app branch from 9fa4b5a to 6477cb4 Compare June 7, 2024 09:39
@OPNA2608 OPNA2608 marked this pull request as ready for review June 7, 2024 09:39
@drupol drupol merged commit 1905dcb into NixOS:master Jun 7, 2024
26 of 29 checks passed
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Successfully created backport PR for release-24.05:

@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-316240-to-release-24.05 origin/release-24.05
cd .worktree/backport-316240-to-release-24.05
git switch --create backport-316240-to-release-24.05
git cherry-pick -x 7f084b0fe1ec8daef5c77fe76d1407b57e4389bb 4a495ec755c826f6b23147a6a77dd2148c934f18 6477cb49a5fd4e6bd2e15bad2f7e19f953f5d4f9

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-316240-to-release-24.05 origin/release-24.05
cd .worktree/backport-316240-to-release-24.05
git switch --create backport-316240-to-release-24.05
git cherry-pick -x 7f084b0fe1ec8daef5c77fe76d1407b57e4389bb 4a495ec755c826f6b23147a6a77dd2148c934f18 6477cb49a5fd4e6bd2e15bad2f7e19f953f5d4f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants