Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domino-chain: init at 1.1 #315862

Merged
merged 1 commit into from
Feb 13, 2025
Merged

domino-chain: init at 1.1 #315862

merged 1 commit into from
Feb 13, 2025
+97 −0

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented May 30, 2024

Description of changes

https://domino-chain.gitlab.io/

If I try to play the game under wayland I run into this bug. Does it happen to anyone else? If so, maybe we should wait until it's fixed before merging.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4360

@fgaz fgaz force-pushed the domino-chain/init branch 2 times, most recently from 4724504 to f4d63b9 Compare September 26, 2024 07:22
flandweber
flandweber suggested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@flandweber flandweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the build fails with

$ nix run github:nixos/nixpkgs?rev=f4d63b94689ad83130d391d945c410f276c062c2#domino-chain
Using portable datadir: ./data
File not found: ./data/domino-chain/images/dominoes.png
Segmentation fault (core dumped)

pkgs/by-name/do/domino-chain/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/do/domino-chain/package.nix Show resolved Hide resolved
@fgaz fgaz force-pushed the domino-chain/init branch from f4d63b9 to f0f00e2 Compare November 8, 2024 08:31
@fgaz fgaz force-pushed the domino-chain/init branch from f0f00e2 to f126950 Compare November 8, 2024 08:31
@fgaz fgaz force-pushed the domino-chain/init branch from f126950 to e58bb7c Compare February 13, 2025 19:43
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 6.topic: games 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Feb 13, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 315862

x86_64-linux

❌ 1 package failed to build:
  • domino-chain

aarch64-linux

❌ 1 package failed to build:
  • domino-chain

@GaetanLepage
Copy link
Contributor

This failure is very weird. It is completely silent:

  Output file.........._tmp/dominoes/domino1498.png, 32 bpp with alpha PNG
  Output file.........._tmp/dominoes/domino1499.png, 32 bpp with alpha PNG
touch _tmp/dominoes/povray_done

@ethancedwards8
Copy link
Member

I've got something similar before when files aren't moved into $out

@fgaz fgaz force-pushed the domino-chain/init branch from e58bb7c to 5396013 Compare February 13, 2025 21:18
@fgaz fgaz force-pushed the domino-chain/init branch from 5396013 to 383adab Compare February 13, 2025 21:19
@fgaz
Copy link
Member Author

fgaz commented Feb 13, 2025

Fixed

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 315862

x86_64-linux

✅ 1 package built:
  • domino-chain

aarch64-linux

✅ 1 package built:
  • domino-chain

GaetanLepage
GaetanLepage approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@GaetanLepage GaetanLepage merged commit 61d8132 into NixOS:master Feb 13, 2025
25 of 27 checks passed
@fgaz fgaz deleted the domino-chain/init branch February 14, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flandweber flandweber flandweber requested changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fgaz @nixos-discourse @GaetanLepage @ethancedwards8 @flandweber