Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-fast-build: init at 1.0.0 #313554

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented May 22, 2024

Description of changes

nix-fast-build combines the power of nix-eval-jobs with nix-output-monitor to speed-up the evaluation and building process.

cc @Mic92

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@isabelroses
Copy link
Member

Result of nixpkgs-review pr 313554 run on x86_64-linux 1

2 packages built:
  • nix-fast-build
  • nix-fast-build.dist

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 22, 2024
@NotAShelf
Copy link
Member

nix-fast-build has recently received its 1.0.0 release, this probably could be updated to use the release tag instead of HEAD.

Also, minor nit but I think with lib; is actively discouraged in the meta field.

@Mic92
Copy link
Member

Mic92 commented Jul 1, 2024

I must have missed this pull request. Please bump this to 1.0.0 and add me as a maintainer as well.

@getchoo getchoo force-pushed the pkgs/nix-fast-build/init branch from b025f97 to ff017e1 Compare July 1, 2024 20:09
@getchoo getchoo requested review from Mic92 and isabelroses July 1, 2024 20:10
@getchoo getchoo removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 1, 2024
@getchoo getchoo force-pushed the pkgs/nix-fast-build/init branch from ff017e1 to cf6c82c Compare July 1, 2024 20:11
@isabelroses
Copy link
Member

Best rename the PR title too.

@isabelroses
Copy link
Member

Result of nixpkgs-review pr 313554 run on x86_64-linux 1

2 packages built:
  • nix-fast-build
  • nix-fast-build.dist

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 1, 2024
@getchoo getchoo changed the title nix-fast-build: init at 0-unstable-2024-05-15 nix-fast-build: init at 1.0.0 Jul 1, 2024
@getchoo getchoo force-pushed the pkgs/nix-fast-build/init branch from cf6c82c to 71f2e6b Compare July 3, 2024 16:34
@getchoo getchoo requested review from Mic92 and isabelroses July 3, 2024 16:34
@getchoo getchoo removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 3, 2024
@NotAShelf
Copy link
Member

Can I encourage you to avoid rec in favor of a top-level let in block? It's bad practice.

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 3, 2024
@getchoo
Copy link
Member Author

getchoo commented Jul 3, 2024

Can I encourage you to avoid rec in favor of a top-level let in block? It's bad practice.

i don't think it matters much in this case as it has basically 0 effect on the expression. #315337 would probably be a better place to discuss it

@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jul 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1803

@eclairevoyant eclairevoyant added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jul 7, 2024
@Mic92 Mic92 merged commit 5cc7a0f into NixOS:master Jul 7, 2024
29 checks passed
@getchoo getchoo deleted the pkgs/nix-fast-build/init branch July 7, 2024 19:46
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants