-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to handing vim and vim plugins #3122
Conversation
Added are: * ctrlp * vim-a * colorsamplerpack * yankring
I don't see a reason for having wrapVim function and vimWrapper and vimHugeXWrapper packages. If you need a system vimrc, whats wrong with ``environment.etc."vimrc".text`` ? Also strictly speaking ``vimHugeXWrapper`` didn't wrap, X-version properly. I.e. running ``gvim`` have console vim version.
I'd like to merge this, except for the "Remove wrapVim" commit. I don't use the wrapper, and I agree that wrappers in general can be confusing to users (includes me). But I'd like @wizeman to get a say in this, as he wrote the wrapper. Also worth mentioning, the discussion of the wrapper and some alternatives to it, in issue #959. |
Its what everybody wants in 2014. They are enabled by default both in ubuntu and archlinux.
Hm, #959 was helpful indeed. It seems that it was agreed that vimrc should be placed in I've also added Feel free to apply this pull request without removing |
Since @tailhook's changes source /etc/vimrc (and /etc/vim/vimrc), I am fine with eliminating the wrapper. I have applied these changes on my local nixpkgs and tested that vim compiles, runs and that my /etc/vimrc gets read. |
Pushed to master (including wrapVim removal). Thanks! |
This pull request consists of following:
vim-plugins
intoshare/vim-plugins
and added topathsToLink
(in analogy toshare/emacs
)systemPackages
and from all the profiles installed by nix-env. The latest profile overrides earlier. I.e. you can install different version of plugin in user profile that in system. (This is included only in vim_configurable)wrapVim
packages. It doesn't work well. And also it only addsvimrc
, what's wrong withenvironment.etc."vimrc".text
? (this makes smaller number of vim versions needed, which is a good thing according to Vim huge nogui #2808)colorsamplerpack
(nice color schemes),yankring
,ctrlp
,vim-a
, those are super-useful and are packaged at least in archlinux, also they do not update very frequently. So I feel it's ok to add them to repository.