Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vfkit: init at 0.5.0 #306438

Closed
wants to merge 1 commit into from
Closed

vfkit: init at 0.5.0 #306438

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 24, 2024

Description of changes

Add https://github.com/crc-org/vfkit

Fixes #306179

cc: @msgilligan

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 24, 2024
@marsam marsam marked this pull request as draft April 25, 2024 01:28
@marsam marsam closed this Apr 25, 2024
@anthr76
Copy link
Contributor

anthr76 commented Apr 25, 2024

This package doesn't work in it's current state

podman machine start
Starting machine "podman-machine-default"
Error: vfkit exited unexpectedly with exit code 1

ldflags = [
"-s"
"-w"
"-X github.com/crc-org/vfkit/pkg/cmdline.gitVersion=${src.rev}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully not needed if you build from a git clone or from a github tarball.


bool vmCanStop(void *machine, void *queue)
{
+#ifdef INCLUDE_TARGET_OSX_12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be filed upstream at github.com/Code-Hex/vz (no idea if this would be accepted or not though )

@cfergeau
Copy link

This package doesn't work in it's current state

podman machine start
Starting machine "podman-machine-default"
Error: vfkit exited unexpectedly with exit code 1

This can happen if codesign --entitlements vf.entitlements -f -s - $out/bin/vfkit did not run as expected. Can you check codesign -dv --entitlements - $(which vfkit) ?

@anthr76
Copy link
Contributor

anthr76 commented Apr 26, 2024

This package doesn't work in it's current state

podman machine start
Starting machine "podman-machine-default"
Error: vfkit exited unexpectedly with exit code 1

This can happen if codesign --entitlements vf.entitlements -f -s - $out/bin/vfkit did not run as expected. Can you check codesign -dv --entitlements - $(which vfkit) ?

This is the contents

codesign -dv --entitlements - $(which vfkit)
Executable=/nix/store/xbl73v9ma2s96sgf6z0mazdsmp736k2w-vfkit-0.5.0/bin/vfkit
Identifier=vfkit
Format=Mach-O thin (arm64)
CodeDirectory v=20400 size=89918 flags=0x2(adhoc) hashes=2805+2 location=embedded
Signature=adhoc
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements count=0 size=12

@cfergeau
Copy link

cfergeau commented Apr 26, 2024

This should return:

% codesign -dv --entitlements - $(which vfkit)

Executable=/usr/local/bin/vfkit
Identifier=vfkit-arm64-55554944d6cf2e8494f7355d8afc1af5531eef5c
Format=Mach-O universal (x86_64 arm64)
CodeDirectory v=20400 size=129517 flags=0x2(adhoc) hashes=4036+7 location=embedded
Signature=adhoc
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements count=0 size=12
[Dict]
	[Key] com.apple.security.network.client
	[Value]
		[Bool] true
	[Key] com.apple.security.network.server
	[Value]
		[Bool] true
	[Key] com.apple.security.virtualization
	[Value]
		[Bool] true

@anthr76
Copy link
Contributor

anthr76 commented Apr 26, 2024

Hmmm I wonder what's going wrong?

@cfergeau
Copy link

I don't know, the nix package builds vfkit "manually", and this is a build issue, I'm not familiar with nix so I can't really debug this.

@sarcasticadmin sarcasticadmin mentioned this pull request Aug 15, 2024
13 tasks
@zowoq zowoq mentioned this pull request Nov 16, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: vfkit
3 participants