-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfkit: init at 0.5.0 #306438
vfkit: init at 0.5.0 #306438
Conversation
This package doesn't work in it's current state
|
ldflags = [ | ||
"-s" | ||
"-w" | ||
"-X github.com/crc-org/vfkit/pkg/cmdline.gitVersion=${src.rev}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully not needed if you build from a git clone or from a github tarball.
|
||
bool vmCanStop(void *machine, void *queue) | ||
{ | ||
+#ifdef INCLUDE_TARGET_OSX_12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be filed upstream at github.com/Code-Hex/vz
(no idea if this would be accepted or not though )
This can happen if |
This is the contents
|
This should return:
|
Hmmm I wonder what's going wrong? |
I don't know, the nix package builds vfkit "manually", and this is a build issue, I'm not familiar with nix so I can't really debug this. |
Description of changes
Add https://github.com/crc-org/vfkit
Fixes #306179
cc: @msgilligan
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.