Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: fix darwin support #305593

Merged
merged 1 commit into from
Apr 20, 2024
Merged

podman: fix darwin support #305593

merged 1 commit into from
Apr 20, 2024

Conversation

nifoc
Copy link
Contributor

@nifoc nifoc commented Apr 20, 2024

Description of changes

Since all of the inherits of ./hardcode-paths.patch only work on Linux - and since it looks like the patch was only recently introduced - only apply the patch on Linux.

The issue was introduced in #301553.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 20, 2024
@ofborg ofborg bot requested review from marsam, saschagrunert and vdemeester April 20, 2024 18:20
@marsam marsam merged commit 4200ea1 into NixOS:master Apr 20, 2024
28 of 29 checks passed
@nifoc nifoc deleted the fix/podman-darwin branch April 20, 2024 22:16
@marsam marsam mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants