-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ayatana-indicator-display: init & add to Lomiri #305516
Merged
SuperSandro2000
merged 3 commits into
NixOS:master
from
OPNA2608:init/lomiri/ayatana-indicator-display
May 23, 2024
Merged
ayatana-indicator-display: init & add to Lomiri #305516
SuperSandro2000
merged 3 commits into
NixOS:master
from
OPNA2608:init/lomiri/ayatana-indicator-display
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Apr 20, 2024
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Apr 20, 2024
@ofborg build nixosTests.lomiri |
OPNA2608
force-pushed
the
init/lomiri/ayatana-indicator-display
branch
from
May 20, 2024 15:52
bc61115
to
dd66b96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
OPNA2608
force-pushed
the
init/lomiri/ayatana-indicator-display
branch
from
May 21, 2024 14:30
dd66b96
to
846318d
Compare
Rebased. |
OPNA2608
force-pushed
the
init/lomiri/ayatana-indicator-display
branch
from
May 22, 2024 08:56
846318d
to
94eec8c
Compare
Bumped to new release. |
OPNA2608
force-pushed
the
init/lomiri/ayatana-indicator-display
branch
from
May 22, 2024 10:10
94eec8c
to
6b5df28
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Failures in other packages & ayatana-indicators test will be fixed by #314043, this is a bug in GLib. Will rebase to resolve merge conflicts ASAP. |
It's an ayatana one, not a lomiri one.
OPNA2608
force-pushed
the
init/lomiri/ayatana-indicator-display
branch
from
May 23, 2024 18:45
6b5df28
to
0115251
Compare
SuperSandro2000
approved these changes
May 23, 2024
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Inits ayatana-indicator-display and adds it to the Lomiri module.
On Lomiri, it only handles screen lock afaict. Not much to show there.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.