Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ayatana-indicator-display: init & add to Lomiri #305516

Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Apr 20, 2024

Description of changes

Inits ayatana-indicator-display and adds it to the Lomiri module.

On Lomiri, it only handles screen lock afaict. Not much to show there.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 20, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 20, 2024
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Apr 20, 2024

@ofborg build nixosTests.lomiri

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-display branch from bc61115 to dd66b96 Compare May 20, 2024 15:52
@OPNA2608 OPNA2608 marked this pull request as ready for review May 20, 2024 15:52
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

nixos/tests/ayatana-indicators.nix Outdated Show resolved Hide resolved
@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-display branch from dd66b96 to 846318d Compare May 21, 2024 14:30
@OPNA2608
Copy link
Contributor Author

Rebased.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-display branch from 846318d to 94eec8c Compare May 22, 2024 08:56
@OPNA2608
Copy link
Contributor Author

Bumped to new release.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-display branch from 94eec8c to 6b5df28 Compare May 22, 2024 10:10
@OPNA2608

This comment was marked as off-topic.

@OPNA2608

This comment was marked as off-topic.

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 23, 2024

Failures in other packages & ayatana-indicators test will be fixed by #314043, this is a bug in GLib.

Will rebase to resolve merge conflicts ASAP.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-display branch from 6b5df28 to 0115251 Compare May 23, 2024 18:45
@SuperSandro2000 SuperSandro2000 merged commit 3e3ac0e into NixOS:master May 23, 2024
23 of 25 checks passed
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants