Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains.jcef: 675 -> 766 #304250

Closed
wants to merge 1 commit into from
Closed

jetbrains.jcef: 675 -> 766 #304250

wants to merge 1 commit into from

Conversation

niknetniko
Copy link
Contributor

Description of changes

Bump JCEF to the required version for the 2024.1 versions (updated in #301635).

I added a patch to disable calling vcpkg for some remote dev stuff.
I couldn't get it to work quickly, but someone else is certainly welcome to fix it.

Additionally, the logs show lines like:

ERR: Display.cpp:1052 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory

I tried a few things (like some changes from our CEF build), but to no avail. Everything I usually check for JCEF (e.g. the markdown preview) seems to work despite these error messages, so perhaps they are not relevant.

Pinging @GenericNerdyUsername, since you have done a lot of work on this in the past.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Apr 15, 2024
@niknetniko
Copy link
Contributor Author

Closing in favour of #309447

@niknetniko niknetniko closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant