Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bump JCEF to the required version for the 2024.1 versions (updated in #301635).
I added a patch to disable calling
vcpkg
for some remote dev stuff.I couldn't get it to work quickly, but someone else is certainly welcome to fix it.
Additionally, the logs show lines like:
I tried a few things (like some changes from our CEF build), but to no avail. Everything I usually check for JCEF (e.g. the markdown preview) seems to work despite these error messages, so perhaps they are not relevant.
Pinging @GenericNerdyUsername, since you have done a lot of work on this in the past.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.