Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.jdk: add updateScript and a test #301653

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

jetbrains.jdk: add updateScript and a test #301653

wants to merge 2 commits into from

Conversation

liff
Copy link
Contributor

@liff liff commented Apr 4, 2024 •
edited
Loading

The update script uses the jbr/release file in IDEA Ultimate’s current release tarball to resolve the latest JBR version JetBrains is currently using in their IDEs.

This only adds the update script, the package version remains the same.

I also added a NixOS test that attempts to verify that JCEF works.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 4, 2024
@niknetniko niknetniko mentioned this pull request Apr 5, 2024
Merged
13 tasks
@liff liff changed the title jetbrains.jdk: add updateScript jetbrains.jdk: add updateScript and a test Apr 6, 2024
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 6, 2024
@karolchmist
Copy link
Member

Result of nixpkgs-review pr 301653 run on x86_64-linux 1

@karolchmist
Copy link
Member

Looks good! But is there a way to test it manually? I use idea, can I somehow test it with it?

@liff
Copy link
Contributor Author

liff commented Apr 8, 2024

This does not change the built package in any way, but if you want to test the changes, you can try the following:

  1. Check out this PR 
    $ nix-shell -p gh --command 'gh pr checkout 302592'
  2. Test the update script: 
    $ nix-shell maintainers/scripts/update.nix --argstr package jetbrains.jdk
  3. Build the updated runtime package. 
    $ nix-build -A jetbrains.jdk
  4. Run the NixOS tests 
    $ nix-build -A nixosTests.jetbrains-jdk

Building the JDK takes a while, so skip 2 and 3 if you don’t want to test that 😄

@karolchmist
Copy link
Member

Running nix-build -A nixosTests.jetbrains-jdk results in no errors 👍

@liff liff force-pushed the jetbrains-jdk/updateScript branch from 393cc20 to b7a6c58 Compare May 22, 2024 17:59
@liff liff mentioned this pull request May 22, 2024
Open
16 tasks
@Qyriad Qyriad added the 6.topic: java Including JDK, tooling, other languages, other VMs label May 26, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@liff liff force-pushed the jetbrains-jdk/updateScript branch 3 times, most recently from 4cc88fb to 4a0c93d Compare September 12, 2024 18:02
@liff liff requested a review from leona-ya September 12, 2024 18:07
@ofborg ofborg bot added 10.rebuild-linux: 11-100 and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 12, 2024
@liff liff force-pushed the jetbrains-jdk/updateScript branch 2 times, most recently from 10a6fd6 to 525d315 Compare September 19, 2024 07:14
@liff
jetbrains.jdk: add a NixOS test
fd31c05 
The test attempts to verify that JCEF works by building a simple browser
application and checking that it can display the `chrome://system` page.
@liff
jetbrains.jdk: add updateScript and a test
90e8a72 
The update script uses the `jbr/release` file in IDEA Ultimate’s
current release tarball to resolve the latest JBR version JetBrains
is currently using in their IDEs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

@GenericNerdyUsername GenericNerdyUsername Awaiting requested review from GenericNerdyUsername

@leona-ya leona-ya Awaiting requested review from leona-ya

Assignees
No one assigned
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liff @karolchmist @Qyriad @wegank