-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quickwit: 0.8.0 -> 0.8.1, default config file #300660
Conversation
It was forgotten to be updated with the last update from NixOS#298589. Fixes eval.
Building this still fails on my 128 GB RAM machine with:
See: #289000 (comment) |
I observed the same failure when building 0.8.0 |
Fine by me, I don't know yet how to disable specific Rust tests though. Feel free to push into my PR here in case you know it! |
I'm not close to a keyboard for long enough to push a commit, but here is an example.
so it shoulb be something like I should have time this weekend, I'm just posting this in case you have time before. |
Hey guys I've been trying to build quickwit with the UI (and finally managed to do it). |
That would indeed be appreciated. Would you he okay with pushing to the branch ? |
@tcheronneau I already left some comments on your PR #307808 |
@tcheronneau Where are those changes, do you have a branch? Feel free to push them into this PR as additional commits for me to review, if you have permission to do that. Otherwise, let me know and I'll pull them. |
@nh2 I don't really know how to come in your PR (not used to github). |
I've prepared a PR but I cannot push to your repo. |
Sorry folks - I didn't see this one when I pushed up #317152. |
Done in #317152. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.