Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonia: 0.7.4 -> 0.7.5 #297761

Merged
merged 1 commit into from
Mar 21, 2024
Merged

harmonia: 0.7.4 -> 0.7.5 #297761

merged 1 commit into from
Mar 21, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 21, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli flokli merged commit 6f4bdd4 into NixOS:master Mar 21, 2024
41 of 42 checks passed
@flokli
Copy link
Contributor

flokli commented Mar 21, 2024

I'd like to see this backported to 23.11, but there's no nix 2.21 there.

Is harmonia 0.7.5 still compatibe with 2.19 (on nixpkgs stable)?

@Mic92
Copy link
Member Author

Mic92 commented Mar 22, 2024

No there were some nix API changes. But it should be also fine to just use fetchpatch on the Bugfix patch.

@flokli
Copy link
Contributor

flokli commented Mar 22, 2024

Ok, I'll do a backport PR fetchpatch' ing this in.

@Mic92 Mic92 deleted the harmonia branch March 22, 2024 09:14
@flokli
Copy link
Contributor

flokli commented Mar 22, 2024

For posterity: Backport PR was opened (and merged) at #297989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants