-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.spylls: init at 0.1.5 #295371
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
--replace poetry.masonry.api poetry.core.masonry.api \ | ||
--replace "poetry>=" "poetry-core>=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you suggest the use of poetry-core to the upstream?
https://github.com/python-poetry/poetry-core?tab=readme-ov-file#why-is-this-required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
zverok/spylls#27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Then please fetch the patch. (or replace --replace
with newer --replace-fail
)
https://nixos.org/manual/nixpkgs/unstable/#fun-substitute-replace-fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ | ||
pytest # hack for fix error: `pytest not installed` | ||
pythonRelaxDepsHook | ||
]; | ||
|
||
pythonRelaxDeps = [ | ||
"pytest" | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ | |
pytest # hack for fix error: `pytest not installed` | |
pythonRelaxDepsHook | |
]; | |
pythonRelaxDeps = [ | |
"pytest" | |
]; |
I can't reproduce such an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natsukium this error is only in version 0.1.5
Can you explain how pythonRelaxDeps work, if a package needs another package in version 0.2.0, but the latest version of the package is 0.2.5, do I need to commit version 0.2.0 and then 0.2.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a package needs another package in version 0.2.0, but the latest version of the package is 0.2.5, do I need to commit version 0.2.0 and then 0.2.5?
No. pythonRelaxDepsHook
simply ignores upstream version constraints.
It does not reference previous versions.
* python312Packages.spylls: init at 0.1.5 * python312Packages.spylls: 0.1.5 -> 0.1.7
Description of changes
Pure Python spell-checker, (almost) full port of Hunspell
https://github.com/zverok/spylls
https://github.com/zverok/spylls/blob/master/CHANGELOG.rst
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.