python311Packages.floret: fix build by supplying <cstdint> #290984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Result of 6 packages built:
|
GaetanLepage
approved these changes
Feb 24, 2024
|
Maybe change the PR name and commit message to |
sarahec
changed the title
delroth
added
the
12.approvals: 1
|
Result of 6 packages built:
|
|
Force-pushed to rebase onto master and rename commit as requested. No files changed. |
delroth
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #290983
Hydra stopped building this package and it appears to be due to a gcc version change.
src/args.ccdepends onuint64_tbeing defined but it wasn't.The fix is to add
#include <cstdint>tosrc/args.cc.This PR adds a patch file that makes that change and enables the patch in
default.nix.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.