Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsForQt5.quickflux: init at 1.1-unstable-2020-11-10 #285553

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Feb 1, 2024

Description of changes

Working towards #99090.

QuickFlux is a library, bringing Facebook's Flux application architecture framework to QML. It's required for building Lomiri's TELEports telegram client.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@OPNA2608 OPNA2608 marked this pull request as draft February 2, 2024 11:31
@OPNA2608 OPNA2608 force-pushed the init/quickflux branch 2 times, most recently from 0b4e9a8 to 90961cb Compare February 2, 2024 18:02
@OPNA2608 OPNA2608 changed the title quickflux: init at 1.1-unstable-2020-11-10 libsForQt5.quickflux: init at 1.1-unstable-2020-11-10 Feb 2, 2024
@OPNA2608 OPNA2608 marked this pull request as ready for review February 2, 2024 19:05
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 8, 2024
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 285553 run on x86_64-linux 1

2 packages built:
  • libsForQt5.quickflux (plasma5Packages.quickflux)
  • libsForQt5.quickflux.dev (plasma5Packages.quickflux.dev)

@pbsds pbsds merged commit d4b4953 into NixOS:master Feb 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants