-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services.gnome.gnome-settings-daemon: allow disabling of arbitrary plugins #284118
base: master
Are you sure you want to change the base?
Conversation
6e714ce
to
64a9729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. Unfortunately, I do not think this is something we want to support:
- the feature will be only useful for a tiny minority of users
- it makes it too easy to shoot oneself into one’s foot
- get a broken system
- change options that trigger larger packager rebuilds can be confusing
- it can be relatively easily achieved by an overlay
- the option description adds non-negligible maintenance cost for updates
Maybe indeed that's a better option -- can you explain a bit more? |
People can just apply the patches to |
On your point of demand: It looks as if there is at least some, for trimming down the Gnome stack:
We can sure discuss ways to reduce the maintenance overhead. |
In pursuit of minimising the Gnome desktop footprint one might be tempted to reduce the number of services that
gnome-settings-daemon
starts.We can observe those by invoking
systemctl --all --user | grep SettingsDaemon
This allows build-time subsetting of systemd services that are installed into the system by
gnome-settings-daemon
to handle its plugins.Note that the set of plugin-induced systemd services that
gnome-system-daemon
injects is not controlled by its NixOS packaging and service definition -- instead it is a direct consequence exclusively controlled by its build process.Description of changes
We patch the Meson build description in the
plugins
subdir to allow subsetting of the plugins.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.