Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services.gnome.gnome-settings-daemon: allow disabling of arbitrary plugins #284118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jan 26, 2024

In pursuit of minimising the Gnome desktop footprint one might be tempted to reduce the number of services that gnome-settings-daemon starts.

We can observe those by invoking systemctl --all --user | grep SettingsDaemon

This allows build-time subsetting of systemd services that are installed into the system by gnome-settings-daemon to handle its plugins.

Note that the set of plugin-induced systemd services that gnome-system-daemon injects is not controlled by its NixOS packaging and service definition -- instead it is a direct consequence exclusively controlled by its build process.

Description of changes

We patch the Meson build description in the plugins subdir to allow subsetting of the plugins.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@deepfire deepfire requested a review from jtojnar as a code owner January 26, 2024 21:59
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 26, 2024
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. Unfortunately, I do not think this is something we want to support:

  • the feature will be only useful for a tiny minority of users
  • it makes it too easy to shoot oneself into one’s foot
    • get a broken system
    • change options that trigger larger packager rebuilds can be confusing
  • it can be relatively easily achieved by an overlay
  • the option description adds non-negligible maintenance cost for updates

@deepfire
Copy link
Contributor Author

it can be relatively easily achieved by an overlay

Maybe indeed that's a better option -- can you explain a bit more?

@jtojnar
Copy link
Member

jtojnar commented Jan 28, 2024

People can just apply the patches to gnome.gnome-settings-daemon using an overlay in their own config.

@deepfire
Copy link
Contributor Author

deepfire commented Jan 28, 2024

On your point of demand: It looks as if there is at least some, for trimming down the Gnome stack:

We can sure discuss ways to reduce the maintenance overhead.

@amaxine amaxine removed their request for review April 27, 2024 17:56
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants