nixos/systemd: Temporarily bring back multi-user -> network-online #283818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvishJerricco
requested review from
Mic92,
zowoq,
mweinelt and
a team
as code owners
github-actions
bot
added
6.topic: nixos
|
Please include the reason for the revert in the commit message. |
ElvishJerricco
force-pushed
the
revert-258680-network-online-x-multi-user
branch
from
c128253 to
d7d1d4a
Compare
|
@alyssais done |
|
on second thought, we can just revert smaller bits of this. |
ElvishJerricco
force-pushed
the
revert-258680-network-online-x-multi-user
branch
from
d7d1d4a to
07e5ead
Compare
ElvishJerricco
changed the title
|
Ok, I've redone this to only revert the part that needs to be reverted. All the rest of the original PR is good even without this part. |
There were several modules, critically including NetworkManager, which were not prepared for this change. Most of the change was good, however. Let's bring back the dependency and change the assertion to a warning for now.
ElvishJerricco
force-pushed
the
revert-258680-network-online-x-multi-user
branch
from
07e5ead to
0d85bf0
Compare
RaitoBezarius
approved these changes
Jan 25, 2024
delroth
added
the
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #282795 and #283717, I think it's best to revert this until we've more thoroughly checked that everything is fixed.
Description of changes
The plan is to bring back the undesirable
multi-user.target -> network-online.targetdependency, but leave in a warning that a unit with anAfter=network-online.targetordering ought to have aWants=network-online.targetdependency. After we've more thoroughly completed this migration in #282795, we can leave in the warning and remove themulti-user.target -> network-online.targetdependency again.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.