Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhwy: disable RVV #283444

Merged
merged 1 commit into from
Jan 29, 2024
Merged

libhwy: disable RVV #283444

merged 1 commit into from
Jan 29, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 24, 2024

It will not work on processors that lack the V extension until runtime dispatch is implemented: google/highway#838

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • riscv64-linux
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

It will not work on processors that lack the V extension until runtime
dispatch is implemented: google/highway#838
@fgaz fgaz force-pushed the libhwy/disable-rvv branch from d5a6cde to 0ff10df Compare January 24, 2024 09:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2024
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the build failure for me

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@fgaz fgaz requested a review from zhaofengli January 25, 2024 09:15
@fgaz fgaz merged commit 0e6d821 into NixOS:master Jan 29, 2024
26 checks passed
@fgaz fgaz deleted the libhwy/disable-rvv branch January 29, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: riscv64 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants