Revert "desktopToDarwinBundle: use imagemagick_light" #282764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
desktopToDarwinBundle
to use imagemagick_light is a breaking change. imagemagick_light does not support png, which causes any package with png icons to fail to build. In particular, this affects inkscape and gimp, which are Darwin channel blockers.I am targeting staging-next #281828 because this change has not yet hit master. There are no builds yet on Hydra since this is a new cycle, and builds of affected packages have not started yet.
I discovered this change while testing #282624 to make sure Darwin channel blockers and packages with workarounds for #166205 reverted all built. I confirmed that mupdf-headless still builds with this commit reverted.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.