adds block_args for autogenerated ids from trustworthy sources #281212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsjobeki
force-pushed
the
nrd/auto-id-prefix
branch
from
8220a91 to
da66141
Compare
github-actions
bot
added
the
8.has: documentation
hsjobeki
force-pushed
the
nrd/auto-id-prefix
branch
from
da66141 to
5247cc1
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
pennae
requested changes
Jan 16, 2024
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
pennae
reviewed
Jan 18, 2024
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
pkgs/tools/nix/nixos-render-docs/src/tests/test_auto_id_prefix.py
Outdated
Show resolved
Hide resolved
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
hsjobeki
force-pushed
the
nrd/auto-id-prefix
branch
4 times, most recently
from
c21ac0e to
d59c8cf
Compare
|
@pennae can you have a look if it looks clean enough for merging. 😃 |
pennae
reviewed
Jan 22, 2024
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
pkgs/tools/nix/nixos-render-docs/src/nixos_render_docs/manual.py
Outdated
Show resolved
Hide resolved
hsjobeki
force-pushed
the
nrd/auto-id-prefix
branch
from
d59c8cf to
96cc68a
Compare
pennae
force-pushed
the
nrd/auto-id-prefix
branch
from
96cc68a to
48a2178
Compare
pennae
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add option to autogenerate heading ids. This is needed if we want to support regular commonmark documentation generated from nix source code. People are not expected to place heading ids in their code comments.
This PR resolves:
#280514
Which is needed for implementing rfc145 in nixpkgs.
@pennae. Thank you a lot for your help with this PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.