mautrix-signal: 0.4.3 -> unstable-2023-12-30

[niklaskorz]

Description of changes

mautrix-signal's latest released version v0.4.3 still uses the Python codebase
which is broken for new devices, see mautrix/signal#388.
The new Go version fixes this by using the official libsignal as a library and
can be upgraded to directly from the Python version.

Fixes #248379.

If anyone wants to try this out in combination with #277368, I also created a combined branch of these changes based on nixos-23.11: github:niklaskorz/nixpkgs/nixos-23.11-mautrix-signal.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[alyaeanyx]

Nice work, thanks!

[Ma27]

Nice! Since I'm currently locked out of my bridge because of the 405 error, I'll happily test this soonish! :)

[alyaeanyx]

LGTM

[Ma27]

Just two small things I noticed. Going to try it out now and hopefully I can report back soon :)

[Ma27]

Bridge is working fine btw 👍

[niklaskorz]

I'm a bit unsure whether libsignal-ffi should be its own package or be part of the mautrix-signal package. Right now, this PR adds libsignal-ffi at version 0.36.1 while the latest version is 0.37.0. I tried running mautrix-signal with 0.37.0, but this leads to errors, so the version of libsignal-ffi must match unfortunately: mautrix/signal#401

[Ma27]

I'm a bit unsure whether libsignal-ffi should be its own package or be part of the mautrix-signal package

At the end of the day it's our job to provide a package set that works together, not a bunch of packages at the latest version (of course, that's not a hard rule, but something we should be keeping in mind generally).

My suggestion would be to still leave a warning in the libsignal-ffi nix expression, but as amintainer you should be pinged anyways on updates.

While you're at it, feel free to also add me to the list of maintainers for mautrix-signal (thought I already was 🤔 ) :)

[niklaskorz]

@Ma27 alright, done :)

@expipiplus1 any remarks from your side? do you still want to maintain the mautrix-signal package?

[Janik-Haag]

didin't review the package only the maintainers part. Btw please clean up your commit history a bit. the libsignal-ffi changes can probably be squashed and the mautrix-signal changes should be squashed into one commit. nixpkgs tries to have a atomic commit history.