-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel_6: Fix empty bzlmod lock file #273774
Conversation
e25e5e2
to
8d23d33
Compare
8d23d33
to
54148bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a better fix available upstream, can we use that? bazelbuild/bazel#20587
Yes, saw that and I'll update the PR. |
This works around an issue with bootstrapping bazel from scratch, see bazelbuild/bazel#20501 Fixes NixOS#273500
54148bd
to
b75fc95
Compare
PTAL, I have incorporated the patch from bazelbuild/bazel#20612 and added a regression test adapted from #262152 |
Looks like it's broken on darwin, not sure if it's preexisting or caused by the PR:
It's the execlog parser though, not bazel itself, so maybe we can just stop building it. |
👍 I added a commit which skips this step on darwin. |
0cf88b7
to
5b91b1c
Compare
Doesn't seem to have worked, though I don't know why. |
Oh no I see, the build of the parser is skipped, but then the install fails since it can't find the parser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to you, sorry.
This currently fails with: ``` > ERROR: /private/var/tmp/_bazel__nixbld1/e8e960336b6dc72b41250252f59936ca/external/remote_java_tools/java_tools/zlib/BUILD.bazel:18:11: Compiling java_tools/zlib/uncompr.c [for tool] failed: The include path '/nix/store/z0nnwdh4p692yvf3qgwgj3bn78w99q6y-python3-3.11.6/include' references a path outside of the execution root. > ERROR: /private/var/tmp/_bazel__nixbld1/e8e960336b6dc72b41250252f59936ca/external/remote_java_tools/java_tools/zlib/BUILD.bazel:18:11: Compiling java_tools/zlib/zutil.c [for tool] failed: The include path '/nix/store/z0nnwdh4p692yvf3qgwgj3bn78w99q6y-python3-3.11.6/include' references a path outside of the execution root. > Target //src/tools/execlog:parser_deploy.jar failed to build ```
5b91b1c
to
7c08dd8
Compare
My bad. Seems like I fixed it this time, builds and tests are green on x86_64-darwin. |
@uri-canva could you have a look again, please? |
closing, superseded by #283480 |
Apologies I'm not very active these days, will look at #283480. |
Description of changes
This works around an issue with bootstrapping bazel from scratch, see
bazelbuild/bazel#20501
Fixes #273500
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.