Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bambu-studio: 01.08.00.62 -> 01.08.01.57 #273350

Merged
merged 1 commit into from
Dec 10, 2023
Merged

bambu-studio: 01.08.00.62 -> 01.08.01.57 #273350

merged 1 commit into from
Dec 10, 2023

Conversation

cab404
Copy link
Member

@cab404 cab404 commented Dec 10, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@cab404 cab404 mentioned this pull request Dec 10, 2023
Merged
13 tasks
@cab404
Copy link
Member Author

cab404 commented Dec 10, 2023

Filament edit crash is gone and it does build.

@norpol norpol mentioned this pull request Dec 10, 2023
Closed
2 tasks
@cab404
Copy link
Member Author

cab404 commented Dec 10, 2023

@ofborg build bambu-studio

@ofborg ofborg bot requested a review from zhaofengli December 10, 2023 17:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 10, 2023
@deftdawg
Copy link
Contributor

deftdawg commented Dec 10, 2023 •
edited
Loading

Was going to test with this, but couldn't get it going...
nix --extra-experimental-features "nix-command flakes" profile install github:cab404/nixpkgs#cab/bambu-1.8.1.57 bambu-studio

So tested with this instead and can confirm no more edit filament crashes. Looks good! 🚀

git clone https://github.com/cab404/nixpkgs --depth 1 -b cab/bambu-1.8.1.57 cab-bambu-nixpkgs \
    && cd cab-bambu-nixpkgs \
    && nix-build -A bambu-studio \
    && result/bin/bambu-studio

@cab404
Copy link
Member Author

cab404 commented Dec 10, 2023

Well, looks like we're good then. Merging <3

@cab404 cab404 merged commit 33f23ce into NixOS:master Dec 10, 2023
JohnRTitor pushed a commit that referenced this pull request Jun 20, 2024
@cab404 @sephalon
bambu-studio: 01.08.00.62 -> 01.08.01.57 (#273350)
0d9aa38 
(cherry picked from commit 33f23ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cab404 @deftdawg