nixos/clevis: guard zfs code behind config.clevis.boot.initrd.enable & skip filesystem with device = null #272061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The rationale behind the expression before was that
clevisDatasets
is empty if clevis is disabled. The problem is that the evaluation ofclevisDatasets
can fail when the users has filesystems withdevice = null
(if you are mounting by label for example), currently causing issues for users that are not using clevis.This introduces two changes:
zfs.nix
.device = null
. Better support for clevis devices by label will be implemented in a followup.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.