Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulloak: init at 0.5.4 #268113

Merged
merged 1 commit into from
Nov 29, 2023
Merged

bulloak: init at 0.5.4 #268113

merged 1 commit into from
Nov 29, 2023

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Nov 17, 2023

Description of changes

Adds bulloak, a utility to generate and check Solidity tests based on the Branching Tree Technique.

https://github.com/alexfertel/bulloak

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 17, 2023
@sikmir
Copy link
Member

sikmir commented Nov 17, 2023

bulloak definition is missed from pkgs/top-level/all-packages.nix. Or move pkgs/development/tools/bulloak/default.nix into pkgs/by-name/bu/bulloak/package.nix.

@beeb
Copy link
Contributor Author

beeb commented Nov 19, 2023

Thanks @sikmir hopefully this looks better.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 19, 2023
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add meta.mainProgram ?

@beeb
Copy link
Contributor Author

beeb commented Nov 29, 2023

Thanks for the input @drupol . What does meta.mainProgram do and why is it needed? What should it contain?

@drupol
Copy link
Contributor

drupol commented Nov 29, 2023

Thanks for the input @drupol . What does meta.mainProgram do and why is it needed? What should it contain?

Check in your IDE for the string mainProgram = " accross nixpkgs repo. You'll find many packages with that attribute in the meta section.

Basically, this attributes inform the user of the executable to use when using ${lib.getExe pkgs.bulloak}.

I also invite you to read this issue: #246386

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks!

@drupol drupol merged commit fbe817f into NixOS:master Nov 29, 2023
@beeb beeb deleted the bulloak branch November 29, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants