martin: 0.9.1 → 0.14.2

[sikmir]

Description of changes

Changelog

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[imincik]

That's a very interesting tool. I didn't know about it. Thanks for packaging !

[sikmir]

protoc binary needs to be patched or replaced with one from nixpkgs:

failed to spawn command `"/build/martin-0.10.0-vendor.tar.gz/protoc-bin-vendored-linux-aarch_64/bin/protoc"

[sikmir]

@nixos/rust Could you advise a proper way to fix it?

[winterqt]

Either patch these binaries, patch martin to not use this crate, or symlink our binaries (from buildPackages) into the respective directories.

[sikmir]

Either patch these binaries, patch martin to not use this crate, or symlink our binaries (from buildPackages) into the respective directories.

I've tried to patch the binary or symlink to nixpkgs protoc, but I've got:

martin> error: the listed checksum of `/build/martin-0.11.3-vendor.tar.gz/protoc-bin-vendored-linux-x86_64/bin/protoc` has changed:
martin> expected: 239cd7cc1888c8855bc2a7ed571d4af3cb9d255fde86b78c1fc1cdabf9248c14
martin> actual:   636f4f115e97302cda39133d3714414ea41cfd5c415d9da2c060e080fd3e8775
martin> directory sources are not intended to be edited, if modifications are required then it is recommended that `[patch]` is used with a forked copy of the source

cargoHash remained the same.

[das-g]

That's inconsistent.

[imincik]

Is this PR still a draft ?

[sikmir]

Is this PR still a draft ?

protoc binary needs to be patched or replaced with one from nixpkgs:

failed to spawn command `"/build/martin-0.10.0-vendor.tar.gz/protoc-bin-vendored-linux-aarch_64/bin/protoc"

I still don't know how to do it.