nixos/forgejo: changelog and migration instructions #267248
Conversation
github-actions
bot
added
6.topic: nixos
|
cc @schmittlauch as per #248310 (comment) |
There was a problem hiding this comment.
I haven't tried the migration steps myself so far (as I do not intend to upgrade my stable forgejo instance yet), but they look plausible to me. I added some possible improvements as comments.
As issue discussions often tend to focus more on complaining and nitpicking of negative things, I explicitly want to thank you for providing the upgrade instructions lacking in the last PR. Things are going well. 🤗
ofborg
bot
added
10.rebuild-darwin: 0
Maybe I could interest you in verifying the instructions for running the forgejo module in gitea mode, that I added? Because I don't think I've got an instance with gitea module left 🙈 |
|
You might be lucky, I see what me and my btrfs snapshots can do this week ;) |
Co-authored-by: Emily <[email protected]>
Co-authored-by: Emily <[email protected]>
as noted <!-- To avoid merge conflicts, consider adding your item at an arbitrary place in the list instead. -->
|
Branch - off in 3 days, so last chance to review this ... |
|
I think 8 of 9 commits is a single logical change -- please squash? |
|
@bendlas Please don't be so much in a hurry for such changes, we can always backport them, and they are not critical for branch-off. Leave the time to review them. |
|
ok, sorry |
There was a problem hiding this comment.
I successfully tested the migration by gitea-impersonation approach, it works like a charm.
As I made the error of running gitea on mariadb and renaming databases there is kind of a pain, I unfortunately could not verify the full migration instructions.
Apart from that I discovered a typo. I can of course submit a follow-up PR for this, but preferred to keep the review feedback tied to the original PR.
| database.user = "gitea"; | ||
| }; | ||
|
|
||
| users.users,gitea = { |
There was a problem hiding this comment.
| users.users,gitea = { | |
| users.users.gitea = { |
There was a problem hiding this comment.
Ah, I see this has already been fixed in 8c441fc.
|
|
||
| ::: {.note} | ||
| Migrating is, while not strictly necessary at this point, highly recommended. | ||
| Both modules and projects are likely to divide further with each release. |
There was a problem hiding this comment.
| Both modules and projects are likely to divide further with each release. | |
| Both modules and projects are likely to diverge further with each release. |
There was a problem hiding this comment.
please do create a new PR
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)