Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: remove jfrankenau #267114

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

katexochen
Copy link
Contributor

They seem to be inactive and not responsive regarding the packages they maintain.

I'll add an issue for the unmaintained packages as soon as this PR is approved.

Please wait at least 1 week before merging this, so the have time to react, see maintainer policy

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 12, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2023
@OPNA2608
Copy link
Contributor

see maintainer policy

You forgot to request a review from them.

Removing the maintainer happens by making a PR on the package, adding that person as a reviewer, and then waiting a week for a reaction.

@OPNA2608 OPNA2608 requested a review from jfrankenau November 13, 2023 15:14
@katexochen
Copy link
Contributor Author

You forgot to request a review from them.

Removing the maintainer happens by making a PR on the package, adding that person as a reviewer, and then waiting a week for a reaction.

Good point. I somehow expected CI to tag them, but makes sense it doesn't know that I think about it.

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 13, 2023
Copy link
Member

@jfrankenau jfrankenau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. While I still use NixOS on my servers, I don't use it as my main desktop OS anymore. I've been already thinking about removing myself from the maintainers list but as most of those pull requests have been automated, it didn't seem too urgent.

@katexochen
Copy link
Contributor Author

Thanks @jfrankenau for the work you did back then! Come back anytime. ❤️

@katexochen katexochen force-pushed the maintainers/jfrankenau branch from f39209c to 2c97a5c Compare November 20, 2023 07:45
@ajs124 ajs124 merged commit f1f62c9 into NixOS:master Nov 20, 2023
@katexochen katexochen deleted the maintainers/jfrankenau branch November 20, 2023 11:27
@ajs124 ajs124 mentioned this pull request Nov 20, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: printing 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants