python311Packages.pydantic-settings: mark broken #267088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tu-maurice
force-pushed
the
fix/python-pydantic-settings
branch
from
9db344a to
388a146
Compare
mweinelt
reviewed
Nov 12, 2023
tu-maurice
force-pushed
the
fix/python-pydantic-settings
branch
from
388a146 to
d26f664
Compare
ofborg
bot
added
10.rebuild-darwin: 0
tu-maurice
force-pushed
the
fix/python-pydantic-settings
branch
from
d26f664 to
b08f66d
Compare
|
Ah. I see. |
|
For future PRs, make sure that the reasoning goes into the commit message, so that when someone only has the Git repo they can still understand why a change was made. |
|
Wouldn't had any issue adding that too before merge. |
|
Was not worth doing another review round about, so I took care of that in 70ccb0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The python module pydantic-settings requires pydantic v2. We only have pydantic v1 packaged. Both versions of pydantic are maintained independently so our pydantic is not outdated, it's just the wrong "flavor".
The python-module was added recently (#251878) and as far as I can see never built successfully.
@mweinelt
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)