Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passt: init at 2023_11_10 #265409

Merged
merged 1 commit into from
Apr 8, 2024
Merged

passt: init at 2023_11_10 #265409

merged 1 commit into from
Apr 8, 2024

Conversation

8aed
Copy link
Contributor

@8aed 8aed commented Nov 4, 2023

Description of changes

This package provides a user-mode networking tool that can be used with virtual machines (passt) and namespaces (pasta), like SLIRP and slirp4netns, which are already packaged in NixOS.

It is especially useful when one wants to provide networking access to an unprivileged container. It uses a different implementation than SLIRP, supports zero-copy for local connections, is more optimized and generally provides higher throughput than other MTU-based solutions. When available, It is the default networking mode for rootlless podman.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2873

@alyssais
Copy link
Member

alyssais commented Nov 5, 2023

@ofborg eval

@alyssais
Copy link
Member

alyssais commented Nov 5, 2023

Please make sure your commit messages follow the guidelines in CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2023
@8aed 8aed force-pushed the patch-init-passt branch from 18653f3 to b106a00 Compare November 5, 2023 11:11
@8aed
Copy link
Contributor Author

8aed commented Nov 5, 2023 •
edited
Loading

oh sorry, I left out the extended commit message when rebasing for some reason.

i'll fix that and the failing checks, and rebase

@8aed 8aed force-pushed the patch-init-passt branch 2 times, most recently from d7a5152 to c8e2dab Compare November 5, 2023 11:21
FliegendeWurst
FliegendeWurst requested changes Nov 5, 2023
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to reference the package in all-packages.nix or move it to the pkgs/by-name hierarchy.

pkgs/os-specific/linux/passt/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/passt/default.nix Outdated Show resolved Hide resolved
@8aed 8aed force-pushed the patch-init-passt branch 4 times, most recently from c24556c to cb221dc Compare November 11, 2023 08:03
@FliegendeWurst FliegendeWurst added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 11, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 11, 2023
FliegendeWurst
FliegendeWurst requested changes Nov 13, 2023
View reviewed changes
pkgs/by-name/pa/passt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/passt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/passt/package.nix Show resolved Hide resolved
pkgs/by-name/pa/passt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/passt/package.nix Outdated Show resolved Hide resolved
@8aed
Copy link
Contributor Author

8aed commented Nov 17, 2023

I've applied the suggested changes and updated to the latest release.

@8aed 8aed requested a review from FliegendeWurst November 17, 2023 15:39
@8aed
passt: init at 0.2023_11_10.5ec3634
4856241 
Add passt, a userspace network stack that can be use to provide unprivileged
network access for virtual machines (using 'passt') or containers (using
'pasta'). See https://passt.top/passt/about/
@8aed 8aed changed the title init: passt at 2023_10_04 init: passt at 2023_11_10 Nov 18, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/has-anyone-tried-podman-5-rc/41011/1

@gautaz
Copy link
Contributor

gautaz commented Mar 8, 2024 •
edited
Loading

Hello,

What is the current status of this PR?
I've experimented it with podman 5 (RC5) as podman 5 seems to be using pasta as the default network provider (see previous discourse reference).
It seems to work so far but needs additional testing.
The result of pasta --version seems rather strange also.

@gautaz gautaz mentioned this pull request Mar 13, 2024
Open
@the-sun-will-rise-tomorrow
Copy link
Contributor

@alyssais @FliegendeWurst Kind ping, this seems ready for review again.

I understand that this is a blocker for Podman v5, CC @marsam @saschagrunert @vdemeester.

@marsam marsam self-requested a review April 4, 2024 13:21
This was referenced Apr 4, 2024
Merged
Closed
vdemeester
vdemeester approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 5, 2024
@bachp bachp merged commit f955c92 into NixOS:master Apr 8, 2024
12 checks passed
@SuperSandro2000 SuperSandro2000 changed the title init: passt at 2023_11_10 passt: init at 2023_11_10 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@8aed @nixos-discourse @alyssais @gautaz @the-sun-will-rise-tomorrow @vdemeester @FliegendeWurst @bachp @wegank