Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pywebview: fix failing build #263548

Merged
merged 1 commit into from
Oct 28, 2023
Merged

python3Packages.pywebview: fix failing build #263548

merged 1 commit into from
Oct 28, 2023

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Oct 26, 2023 •
edited
Loading

Description of changes

See https://hydra.nixos.org/build/238312884/nixlog/2

Introduced by #251878

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jojosch October 26, 2023 10:36
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2826

natsukium
natsukium requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the commit message and PR title to python311Packages.pywebview from pythonPackages.pywebview?
pythonPackages means packages for python2.

@Scrumplex Scrumplex force-pushed the pkgs/pywebview/fix-3.11 branch from 40c7cdd to f62d3db Compare October 28, 2023 07:47
@Scrumplex Scrumplex requested a review from natsukium October 28, 2023 07:47
@Scrumplex Scrumplex changed the title pythonPackages.pywebview: fix failing build python3Packages.pywebview: fix failing build Oct 28, 2023
@Scrumplex Scrumplex force-pushed the pkgs/pywebview/fix-3.11 branch from f62d3db to 9f04e2c Compare October 28, 2023 07:48
@Scrumplex Scrumplex force-pushed the pkgs/pywebview/fix-3.11 branch from 9f04e2c to 92ad365 Compare October 28, 2023 08:10
@natsukium
Copy link
Member

@ofborg build python311Packages.pywebview

@natsukium
Copy link
Member

Result of nixpkgs-review pr 263548 run on x86_64-linux 1

2 packages failed to build:
  • python310Packages.pywebview
  • python310Packages.pywebview.dist
4 packages built:
  • jellyfin-mpv-shim
  • jellyfin-mpv-shim.dist
  • python311Packages.pywebview
  • python311Packages.pywebview.dist

@natsukium
Copy link
Member

@ofborg build python310Packages.pywebview

natsukium
natsukium approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit 59cc59d into NixOS:master Oct 28, 2023
@Scrumplex Scrumplex deleted the pkgs/pywebview/fix-3.11 branch September 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@jojosch jojosch Awaiting requested review from jojosch

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scrumplex @nixos-discourse @natsukium