nixos/systemd-boot: conform backend to rfc 125 #263442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg test systemd-boot |
JulienMalka
force-pushed
the
systemd-boot-bootspec
branch
2 times, most recently
from
6c105ee to
b4bfb45
Compare
13 tasks
| kernel_params = "init=%s " % profile_path(profile, generation, specialisation, "init") | ||
| kernel_params = "init=%s " % bootspec.init | ||
|
|
||
| kernel_params = kernel_params + " ".join(bootspec.kernelParams) |
There was a problem hiding this comment.
Suggested change
| kernel_params = kernel_params + " ".join(bootspec.kernelParams) | |
| kernel_params = " ".join([f"init={bootspec.init}"] + bootspec.kernelParams) |
RaitoBezarius
requested changes
Nov 14, 2023
Now the builder is using Bootspec documents.
RaitoBezarius
force-pushed
the
systemd-boot-bootspec
branch
from
b4bfb45 to
372d07d
Compare
RaitoBezarius
approved these changes
Nov 15, 2023
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This converts the
systemd-bootbackend to use the bootspec to conform to RCF 125.The only functional difference with before, is that the
describe_generationfunction as been removed and replaced by thelabelitem of the bootspec, this will induce a change of format of the entries, but should contain the same information as before.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)