Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.content-hub: init at 1.1.0 #262406

Merged
1 commit merged into from
Jan 18, 2024
Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 20, 2023

Description of changes

Working towards #99090.

Content Hub is the system Lomiri uses for securely exchanging data between applications. It integrates with D-Bus mediation via AppArmor if present, but doesn't require it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 21, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/content-hub branch from 14c0c5d to a24ef1b Compare December 23, 2023 22:38
@OPNA2608

This comment was marked as resolved.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3246

@OPNA2608

This comment was marked as resolved.

@OPNA2608 OPNA2608 marked this pull request as draft January 12, 2024 22:08
@OPNA2608 OPNA2608 force-pushed the init/lomiri/content-hub branch from 14abd66 to b307a6b Compare January 14, 2024 17:41
@OPNA2608 OPNA2608 marked this pull request as ready for review January 14, 2024 17:41
@OPNA2608 OPNA2608 force-pushed the init/lomiri/content-hub branch from b307a6b to abcbc3b Compare January 16, 2024 01:45
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Result of nixpkgs-review pr 262406 run on x86_64-linux 1

3 packages built:
  • lomiri.content-hub
  • lomiri.content-hub.dev
  • lomiri.content-hub.examples

@ghost ghost merged commit aaae35a into NixOS:master Jan 18, 2024
22 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants