lomiri.lomiri-sounds: init at 22.02 #260947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
OPNA2608
force-pushed
the
init/lomiri/lomiri-sounds
branch
from
825363f to
8195f94
Compare
OPNA2608
force-pushed
the
init/lomiri/lomiri-sounds
branch
from
8195f94 to
c20c15f
Compare
This was referenced Dec 31, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3246 |
OPNA2608
force-pushed
the
init/lomiri/lomiri-sounds
branch
from
c20c15f to
684ba43
Compare
ghost
reviewed
Jan 19, 2024
Comment on lines
+28
to
+30
| nativeBuildInputs = [ | ||
| cmake | ||
| ]; |
There was a problem hiding this comment.
should validatePkgConfig be here as well?
... doesn't look like it is all that common, only included in 18 files in nixpkgs/pkgs/...
There was a problem hiding this comment.
Interesting… Didn't know that was a thing. I'll keep it in mind!
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
lomiri-sounds are sounds belonging to Lomiri… Duh.
Pure data, save for a pkg-config file. Some indicators & the Lomiri clock app directly depend on them.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)